Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/17191#discussion_r106607806
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -836,17 +836,29 @@ class Analyzer(
Generate(newG.asInstanceOf[Generator], join, outer, qualifier,
output, child)
}
+ // If grouping keys have unresolved expressions, we need to replace
them with resolved one
+ // in SELECT clauses.
+ case agg @ Aggregate(groups, aggs, child)
+ if child.resolved && aggs.forall(_.resolved) &&
groups.exists(!_.resolved) =>
+ agg.copy(groupingExpressions = groups.map {
+ case u: UnresolvedAttribute =>
+ aggs.find(ne => resolver(ne.name, u.name)).map {
+ case alias @ Alias(e, _) => e
+ case e => e
+ }.getOrElse(u)
+ case e => e
+ })
+
--- End diff --
The code block you suggested has some rules for replacing wildcards and so
I feel putting this rule there is a little weird. But, I don't have a strong
opinion on this, so both is okay to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
