Github user zero323 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17321#discussion_r106626759
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/fpm/FPGrowth.scala ---
    @@ -37,7 +37,20 @@ import org.apache.spark.sql.types._
     /**
      * Common params for FPGrowth and FPGrowthModel
      */
    -private[fpm] trait FPGrowthParams extends Params with HasFeaturesCol with 
HasPredictionCol {
    +private[fpm] trait FPGrowthParams extends Params with HasPredictionCol {
    +
    +  /**
    +   * Items column name.
    +   * Default: "items"
    +   * @group param
    +   */
    +  @Since("2.2.0")
    --- End diff --
    
    `FPGrowthParams` has been annotated before so I decided to make it 
consistent. I can remove annotation here, but then we should probably follow 
through and remove the rest.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to