Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/17088#discussion_r106677939
--- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
---
@@ -1390,7 +1401,34 @@ class DAGScheduler(
}
} else {
logDebug("Additional executor lost message for " + execId +
- "(epoch " + currentEpoch + ")")
+ "(epoch " + currentEpoch + ")")
+ }
+ }
+
+ private[scheduler] def removeExecutorAndUnregisterOutputOnHost(
+ execId: String,
+ host: String,
+ maybeEpoch: Option[Long] = None) {
--- End diff --
nit: add return type `: Unit =`
we didn't adopt that convention (nor did scala) till after a lot of this
class was written, hence the inconsistency in this file, but new changes should
follow this style.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
