GitHub user hhbyyh opened a pull request:
https://github.com/apache/spark/pull/17336
[SPARK-20003] [ML] FPGrowthModel setMinConfidence should affect rules
generation and transform
## What changes were proposed in this pull request?
jira: https://issues.apache.org/jira/browse/SPARK-20003
I was doing some test and found the issue. FPGrowthModel `setMinConfidence`
should always affect rules generation and transform.
Currently associationRules in FPGrowthModel is a lazy val and
`setMinConfidence` in FPGrowthModel has no impact once associationRules got
computed .
I try to cache the associationRules to avoid re-computation if
`minConfidence` is not changed, but this makes FPGrowthModel somehow stateful.
Let me know if there's any concern.
## How was this patch tested?
new unit test and I strength the unit test for model save/load to ensure
the cache mechanism.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hhbyyh/spark fpmodelminconf
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/17336.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #17336
----
commit 3398d62d7e9065f5baf3c7f3ac1525ce60259ece
Author: Yuhao Yang <[email protected]>
Date: 2017-03-17T18:27:42Z
set fpgrwothmodel minconf
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
