Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15363#discussion_r106773716
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/joins.scala 
---
    @@ -83,9 +411,19 @@ object ReorderJoin extends Rule[LogicalPlan] with 
PredicateHelper {
       }
     
       def apply(plan: LogicalPlan): LogicalPlan = plan transform {
    -    case j @ ExtractFiltersAndInnerJoins(input, conditions)
    +    case ExtractFiltersAndInnerJoins(input, conditions)
             if input.size > 2 && conditions.nonEmpty =>
    -      createOrderedJoin(input, conditions)
    +      if (conf.starSchemaDetection && !conf.cboEnabled) {
    --- End diff --
    
    I don't think this algorithm conflicts with CBO, thought it conflicts with 
the other join reordering rule.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to