Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/2436#discussion_r17695987
--- Diff: core/src/main/scala/org/apache/spark/deploy/master/Master.scala
---
@@ -491,14 +491,13 @@ private[spark] class Master(
val shuffledAliveWorkers = Random.shuffle(workers.toSeq.filter(_.state
== WorkerState.ALIVE))
val aliveWorkerNum = shuffledAliveWorkers.size
var curPos = 0
+ var stopPos = aliveWorkerNum
for (driver <- waitingDrivers.toList) { // iterate over a copy of
waitingDrivers
// We assign workers to each waiting driver in a round-robin
fashion. For each driver, we
// start from the last worker that was assigned a driver, and
continue onwards until we have
// explored all alive workers.
- curPos = (curPos + 1) % aliveWorkerNum
- val startPos = curPos
--- End diff --
Yeah, I noticed and wrote same code.
(2014/09/18 6:31), andrewor14 wrote:
>
> In core/src/main/scala/org/apache/spark/deploy/master/Master.scala:
>
> > for (driver <- waitingDrivers.toList) { // iterate over a copy of
waitingDrivers
> > // We assign workers to each waiting driver in a round-robin
fashion. For each driver, we
> > // start from the last worker that was assigned a driver, and
continue onwards until we have
> > // explored all alive workers.
> > - curPos = (curPos + 1) % aliveWorkerNum
> > - val startPos = curPos
>
> This is what I mean:
> andrewor14@apache:master...andrewor14:fix-standalone-cluster
>
<https://github.com/andrewor14/spark/compare/apache:master...andrewor14:fix-standalone-cluster>
>
> â
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/spark/pull/2436/files#r17695766>.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
