Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/17166#discussion_r106789297
--- Diff: core/src/test/scala/org/apache/spark/SparkContextSuite.scala ---
@@ -540,6 +540,39 @@ class SparkContextSuite extends SparkFunSuite with
LocalSparkContext with Eventu
}
}
+ // Launches one task that will run forever. Once the SparkListener
detects the task has
+ // started, kill and re-schedule it. The second run of the task will
complete immediately.
+ // If this test times out, then the first version of the task wasn't
killed successfully.
+ test("Killing tasks") {
+ sc = new SparkContext(new
SparkConf().setAppName("test").setMaster("local"))
+
+ SparkContextSuite.isTaskStarted = false
+ SparkContextSuite.taskKilled = false
+
+ val listener = new SparkListener {
+ override def onTaskStart(taskStart: SparkListenerTaskStart): Unit = {
+ eventually(timeout(10.seconds)) {
+ assert(SparkContextSuite.isTaskStarted)
+ }
+ if (!SparkContextSuite.taskKilled) {
+ SparkContextSuite.taskKilled = true
+ sc.killTaskAttempt(taskStart.taskInfo.taskId, true, "first
attempt will hang")
+ }
+ }
+ }
+ sc.addSparkListener(listener)
+ eventually(timeout(20.seconds)) {
+ sc.parallelize(1 to 1).foreach { x =>
+ // first attempt will hang
+ if (!SparkContextSuite.isTaskStarted) {
+ SparkContextSuite.isTaskStarted = true
+ Thread.sleep(9999999)
+ }
+ // second attempt succeeds immediately
+ }
--- End diff --
Nothing actually runs in this test currently - we need to force the RDD's
computation (a count() or runJob here)
Also, we need to validate that the second task actually ran (which is why
the bug in the test was not detected).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
