Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/2378#discussion_r17698673
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Matrices.scala
---
@@ -64,6 +64,12 @@ class DenseMatrix(val numRows: Int, val numCols: Int,
val values: Array[Double])
override def toArray: Array[Double] = values
private[mllib] override def toBreeze: BM[Double] = new
BDM[Double](numRows, numCols, values)
+
+ override def equals(o: Any) = o match {
--- End diff --
Should this not check values? Even though that would be expensive, it
should be necessary to match the expected behavior of equals().
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
