Github user srowen commented on a diff in the pull request:
    --- Diff: 
    @@ -37,13 +37,24 @@
      * A {@link ManagedBuffer} backed by a segment in a file.
     public final class FileSegmentManagedBuffer extends ManagedBuffer {
    -  private final TransportConf conf;
    +  private final boolean lazyFileDescriptor;
    +  private final int memoryMapBytes;
       private final File file;
       private final long offset;
       private final long length;
       public FileSegmentManagedBuffer(TransportConf conf, File file, long 
offset, long length) {
    -    this.conf = conf;
    +    this(conf.lazyFileDescriptor(), conf.memoryMapBytes(), file, offset, 
    +  }
    +  public FileSegmentManagedBuffer(
    --- End diff --
    Just don't add a new constructor. The existing one can set the new fields. 

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

Reply via email to