Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16626#discussion_r107050210
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -1860,4 +1861,115 @@ class HiveDDLSuite
}
}
}
+
+ hiveFormats.foreach { tableType =>
+ test(s"alter hive serde table add columns -- partitioned -
$tableType") {
+ withTable("tab") {
+ sql(
+ s"""
+ |CREATE TABLE tab (c1 int, c2 int)
+ |PARTITIONED BY (c3 int) STORED AS $tableType
+ """.stripMargin)
+
+ sql("INSERT INTO tab PARTITION (c3=1) VALUES (1, 2)")
+ sql("ALTER TABLE tab ADD COLUMNS (c4 int)")
+
+ checkAnswer(
+ sql("SELECT * FROM tab WHERE c3 = 1"),
+ Seq(Row(1, 2, null, 1))
+ )
+ assert(spark.table("tab").schema
+ .contains(StructField("c4", IntegerType)))
+ sql("INSERT INTO tab PARTITION (c3=2) VALUES (2, 3, 4)")
+ checkAnswer(
+ spark.table("tab"),
+ Seq(Row(1, 2, null, 1), Row(2, 3, 4, 2))
+ )
+ checkAnswer(
+ sql("SELECT * FROM tab WHERE c3 = 2 AND c4 IS NOT NULL"),
+ Seq(Row(2, 3, 4, 2))
+ )
+
+ sql("ALTER TABLE tab ADD COLUMNS (c5 char(10))")
+ assert(spark.table("tab").schema.find(_.name == "c5")
+ .get.metadata.getString("HIVE_TYPE_STRING") == "char(10)")
+ }
+ }
+ }
+
+ hiveFormats.foreach { tableType =>
+ test(s"alter hive serde table add columns -- with predicate -
$tableType ") {
+ withTable("tab") {
+ sql(s"CREATE TABLE tab (c1 int, c2 int) STORED AS $tableType")
+ sql("INSERT INTO tab VALUES (1, 2)")
+ sql("ALTER TABLE tab ADD COLUMNS (c4 int)")
+ checkAnswer(
+ sql("SELECT * FROM tab WHERE c4 IS NULL"),
+ Seq(Row(1, 2, null))
+ )
+ assert(spark.table("tab").schema
+ .contains(StructField("c4", IntegerType)))
+ sql("INSERT INTO tab VALUES (2, 3, 4)")
+ checkAnswer(
+ sql("SELECT * FROM tab WHERE c4 = 4 "),
+ Seq(Row(2, 3, 4))
+ )
+ checkAnswer(
+ spark.table("tab"),
+ Seq(Row(1, 2, null), Row(2, 3, 4))
+ )
+ }
+ }
+ }
+
+ Seq("orc", "ORC", "org.apache.spark.sql.hive.orc",
+ "org.apache.spark.sql.hive.orc.DefaultSource").foreach { source =>
+ test(s"alter datasource table add columns - $source format not
supported") {
+ withTable("tab") {
+ sql(s"CREATE TABLE tab (c1 int) USING $source")
+ val e = intercept[AnalysisException] {
+ sql("ALTER TABLE tab ADD COLUMNS (c2 int)")
+ }.getMessage
+ assert(
+ e.contains(s"ALTER ADD COLUMNS does not support datasource table
with type"))
+ }
+ }
+ }
+
+ Seq("true", "false").foreach { caseSensitive =>
+ test(s"alter add columns with existing column name - caseSensitive
$caseSensitive") {
+ withSQLConf(SQLConf.CASE_SENSITIVE.key -> caseSensitive) {
+ withTable("tab") {
+ sql("CREATE TABLE tab (c1 int) PARTITIONED BY (c2 int) STORED AS
PARQUET")
+ if (caseSensitive == "false") {
--- End diff --
if (!caseSensitive)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
