Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/2226#discussion_r17703451
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/SparkHadoopWriter.scala ---
@@ -0,0 +1,213 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.hive
+
+import java.io.IOException
+import java.text.NumberFormat
+import java.util.Date
+
+import scala.collection.mutable
+
+import org.apache.hadoop.fs.Path
+import org.apache.hadoop.hive.conf.HiveConf.ConfVars
+import org.apache.hadoop.hive.ql.exec.{FileSinkOperator, Utilities}
+import org.apache.hadoop.hive.ql.io.{HiveFileFormatUtils, HiveOutputFormat}
+import org.apache.hadoop.hive.ql.plan.FileSinkDesc
+import org.apache.hadoop.io.Writable
+import org.apache.hadoop.mapred._
+
+import org.apache.spark.sql.Row
+import org.apache.spark.{Logging, SerializableWritable, SparkHadoopWriter}
+
+/**
+ * Internal helper class that saves an RDD using a Hive OutputFormat.
+ * It is based on [[SparkHadoopWriter]].
+ */
+private[hive] class SparkHiveWriterContainer(
+ @transient jobConf: JobConf,
+ fileSinkConf: FileSinkDesc)
+ extends Logging
+ with SparkHadoopMapRedUtil
+ with Serializable {
+
+ private val now = new Date()
+ protected val conf = new SerializableWritable(jobConf)
+
+ private var jobID = 0
+ private var splitID = 0
+ private var attemptID = 0
+ private var jID: SerializableWritable[JobID] = null
+ private var taID: SerializableWritable[TaskAttemptID] = null
+
+ @transient private var writer: FileSinkOperator.RecordWriter = null
+ @transient private lazy val committer = conf.value.getOutputCommitter
+ @transient private lazy val jobContext = newJobContext(conf.value,
jID.value)
+ @transient private lazy val taskContext =
newTaskAttemptContext(conf.value, taID.value)
+ @transient private lazy val outputFormat =
+
conf.value.getOutputFormat.asInstanceOf[HiveOutputFormat[AnyRef,Writable]]
+
+ def driverSideSetup() {
+ setIDs(0, 0, 0)
+ setConfParams()
+ committer.setupJob(jobContext)
+ }
+
+ def executorSideSetup(jobId: Int, splitId: Int, attemptId: Int) {
+ setIDs(jobId, splitId, attemptId)
+ setConfParams()
+ committer.setupTask(taskContext)
+ }
+
+ /**
+ * Create a `HiveRecordWriter`. A relative dynamic partition path can be
used to create a writer
+ * for writing data to a dynamic partition.
+ */
+ def open() {
+ writer = HiveFileFormatUtils.getHiveRecordWriter(
+ conf.value,
+ fileSinkConf.getTableInfo,
+ conf.value.getOutputValueClass.asInstanceOf[Class[Writable]],
+ fileSinkConf,
+ FileOutputFormat.getTaskOutputPath(conf.value, getOutputName),
+ Reporter.NULL)
+ }
+
+ protected def getOutputName: String = {
+ val numberFormat = NumberFormat.getInstance()
+ numberFormat.setMinimumIntegerDigits(5)
+ numberFormat.setGroupingUsed(false)
+ val extension = Utilities.getFileExtension(conf.value,
fileSinkConf.getCompressed, outputFormat)
+ "part-" + numberFormat.format(splitID) + extension
+ }
+
+ def getLocalFileWriter(row: Row): FileSinkOperator.RecordWriter = writer
+
+ def close() {
+ // Seems the boolean value passed into close does not matter.
+ writer.close(false)
+ }
+
+ def commit() {
+ if (committer.needsTaskCommit(taskContext)) {
+ try {
+ committer.commitTask(taskContext)
+ logInfo (taID + ": Committed")
+ } catch {
+ case e: IOException =>
+ logError("Error committing the output of task: " + taID.value, e)
+ committer.abortTask(taskContext)
+ throw e
+ }
+ } else {
+ logInfo("No need to commit output of task: " + taID.value)
+ }
+ }
+
+ def commitJob() {
+ committer.commitJob(jobContext)
+ }
+
+ // ********* Private Functions *********
+
+ private def setIDs(jobId: Int, splitId: Int, attemptId: Int) {
+ jobID = jobId
+ splitID = splitId
+ attemptID = attemptId
+
+ jID = new
SerializableWritable[JobID](SparkHadoopWriter.createJobID(now, jobId))
+ taID = new SerializableWritable[TaskAttemptID](
+ new TaskAttemptID(new TaskID(jID.value, true, splitID), attemptID))
+ }
+
+ private def setConfParams() {
+ conf.value.set("mapred.job.id", jID.value.toString)
+ conf.value.set("mapred.tip.id", taID.value.getTaskID.toString)
+ conf.value.set("mapred.task.id", taID.value.toString)
+ conf.value.setBoolean("mapred.task.is.map", true)
+ conf.value.setInt("mapred.task.partition", splitID)
+ }
+}
+
+private[hive] object SparkHiveWriterContainer {
+ def createPathFromString(path: String, conf: JobConf): Path = {
+ if (path == null) {
+ throw new IllegalArgumentException("Output path is null")
+ }
+ val outputPath = new Path(path)
+ val fs = outputPath.getFileSystem(conf)
+ if (outputPath == null || fs == null) {
+ throw new IllegalArgumentException("Incorrectly formatted output
path")
+ }
+ outputPath.makeQualified(fs.getUri, fs.getWorkingDirectory)
+ }
+}
+
+private[spark] class SparkHiveDynamicPartitionWriterContainer(
+ @transient jobConf: JobConf,
+ fileSinkConf: FileSinkDesc,
+ dynamicPartColNames: Array[String])
+ extends SparkHiveWriterContainer(jobConf, fileSinkConf) {
+
+ private val defaultPartName = jobConf.get(
+ ConfVars.DEFAULTPARTITIONNAME.varname,
ConfVars.DEFAULTPARTITIONNAME.defaultVal)
+
+ @transient private var writers: mutable.HashMap[String,
FileSinkOperator.RecordWriter] = _
+
+ override def open(): Unit = {
+ writers = mutable.HashMap.empty[String, FileSinkOperator.RecordWriter]
+ }
+
+ override def close(): Unit = {
+ writers.values.foreach(_.close(false))
+ }
+
+ override def getLocalFileWriter(row: Row): FileSinkOperator.RecordWriter
= {
+ val dynamicPartPath = dynamicPartColNames
+ .zip(row.takeRight(dynamicPartColNames.length))
+ .map { case (col, rawVal) =>
+ val string = String.valueOf(rawVal)
+ s"/$col=${if (rawVal == null || string.isEmpty) defaultPartName
else string}"
+ }
+ .mkString
+
+ val path = {
--- End diff --
Good point.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
