Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14731#discussion_r107161471
  
    --- Diff: 
streaming/src/test/scala/org/apache/spark/streaming/TestSuiteBase.scala ---
    @@ -557,4 +557,16 @@ trait TestSuiteBase extends SparkFunSuite with 
BeforeAndAfter with Logging {
           verifyOutput[W](output.toSeq, expectedOutput, useSet)
         }
       }
    +
    +  /**
    +   * Creates a temporary directory, which is then passed to `f` and will 
be deleted after `f`
    +   * returns.
    +   * (originally from `SqlTestUtils`.)
    +   * @todo Probably this method should be moved to a more general place
    +   */
    +  protected def withTempDir(f: File => Unit): Unit = {
    --- End diff --
    
    I see, it's only otherwise defined in the SQL test utils class. Well 
something we could unify one day, maybe not such a big deal now here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to