Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/17377#discussion_r107170585
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala
---
@@ -1083,83 +1083,59 @@ class JsonSuite extends QueryTest with
SharedSQLContext with TestJsonData {
}
test("Corrupt records: PERMISSIVE mode, without designated column for
malformed records") {
- withTempView("jsonTable") {
- val schema = StructType(
- StructField("a", StringType, true) ::
- StructField("b", StringType, true) ::
- StructField("c", StringType, true) :: Nil)
+ val schema = StructType(
--- End diff --
While trying to check related other PRs, I saw some minor comments in
https://github.com/apache/spark/pull/14929.
The actual changes are as below:
**From**
```
withTempView("jsonTable") {
...
jsonDF.createOrReplaceTempView("jsonTable")
...
sql(
"""
|SELECT a, b, c
|FROM jsonTable
""".stripMargin),
...
}
```
**To**
```
jsonDF.select($"a", $"b", $"c"),
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
