Github user squito commented on the issue:
https://github.com/apache/spark/pull/17364
> Note that as the exception handler tries to close resources before
calling committer.abortTask(taskAttemptContext), without this patch a failing
releaseResources() means that abortTask() isn't invoked, though hopefully
abortJob will handle tasks too
it doesn't look that way to me -- the `abortTask` is in a `finally`, so it
should get called no matter what.
You could add a very targeted regression test -- create the
`ExecuteWriteTask` with mock OutputFormats, have those mocks throw an exception
on `close`. Then make sure two calls to `releaseResources` work correctly.
Your change is obviously correct, but would help avoid future regressions.
in any case, lgtm
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
