Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/17166#discussion_r107273296
--- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala ---
@@ -302,12 +298,12 @@ private[spark] class Executor(
// If this task has been killed before we deserialized it, let's
quit now. Otherwise,
// continue executing the task.
- if (killed) {
+ if (maybeKillReason.isDefined) {
// Throw an exception rather than returning, because returning
within a try{} block
// causes a NonLocalReturnControl exception to be thrown. The
NonLocalReturnControl
// exception will be caught by the catch block, leading to an
incorrect ExceptionFailure
// for the task.
- throw new TaskKilledException
+ throw new TaskKilledException(maybeKillReason.get)
--- End diff --
Fixed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
