Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/17324#discussion_r107299906
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Imputer.scala ---
@@ -75,6 +75,8 @@ private[feature] trait ImputerParams extends Params with
HasInputCols {
/** Validates and transforms the input schema. */
protected def validateAndTransformSchema(schema: StructType): StructType
= {
+ require(get(inputCols).isDefined, "Input cols must be defined first.")
--- End diff --
As I mentioned in #17316, is this really required? Since a non-set param
for these will in any case throw an exception during `transformSchema` (or
`fit`, or `transform`) with "no default value found"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
