Github user tdas commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17361#discussion_r107307445
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/streaming/FlatMapGroupsWithStateSuite.scala
 ---
    @@ -519,6 +588,52 @@ class FlatMapGroupsWithStateSuite extends 
StateStoreMetricsTest with BeforeAndAf
         )
       }
     
    +  test("flatMapGroupsWithState - streaming with event time timeout") {
    +    // Function to maintain the max event time
    +    // Returns the max event time in the state, or -1 if the state was 
removed by timeout
    +    val stateFunc = (
    +        key: String,
    +        values: Iterator[(String, Long)],
    +        state: KeyedState[Long]) => {
    +      val timeoutDelay = 5
    +      if (key != "a") {
    +        Iterator.empty
    +      } else {
    +        if (state.hasTimedOut) {
    +          state.remove()
    +          Iterator((key, -1))
    +        } else {
    +          val valuesSeq = values.toSeq
    +          val maxEventTime = math.max(valuesSeq.map(_._2).max, 
state.getOption.getOrElse(0L))
    +          val timeoutTimestampMs = maxEventTime + timeoutDelay
    +          state.update(maxEventTime)
    +          state.setTimeoutTimestamp(timeoutTimestampMs * 1000)
    +          Iterator((key, maxEventTime.toInt))
    +        }
    +      }
    +    }
    +    val inputData = MemoryStream[(String, Int)]
    +    val result =
    +      inputData.toDS
    +        .select($"_1".as("key"), $"_2".cast("timestamp").as("eventTime"))
    +        .withWatermark("eventTime", "10 seconds")
    +        .as[(String, Long)]
    +        .groupByKey[String]((x: (String, Long)) => x._1)
    +        .flatMapGroupsWithState[Long, (String, Int)](Update, 
EventTimeTimeout)(stateFunc)
    --- End diff --
    
    I was debugging and I left them there thinking it help readability of 
tests. I can remove them. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to