Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2441#issuecomment-55990116
Overall I think this is better, thanks! One minor issue is that
`hive-thriftserver` is missing from the SQL tests (Sorry, I think I left this
out when you asked).
>Only SQL files have been modified
SQL and non-SQL files have been modified
Only non-SQL files have been modified
- 1) looks good to me
- 2) runs all tests, hive is included
- 3) runs all tests, hive is not included
Is there a reason for the difference in the 2 & 3? I think its okay to
only run hive tests when catalyst, sql, or infrastructure (scripts, build
files, etc) changes. Though I'll let others chime in here too.
/cc @liancheng @JoshRosen
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
