Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/17302#discussion_r107345571
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/object.scala
---
@@ -41,7 +41,20 @@ object CatalystSerde {
}
def generateObjAttr[T : Encoder]: Attribute = {
- AttributeReference("obj", encoderFor[T].deserializer.dataType,
nullable = false)()
+ val deserializer = encoderFor[T].deserializer
+ val dataType = deserializer.dataType
+ val nullable = if (deserializer.childrenResolved) {
--- End diff --
I checked the test code.
The case when `deserializer.resolved` is true, is a `CreateExternalRow`
with no children. (because it refers to `nonExistentName`). I don't think this
is a normal use case.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
