Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/17395#discussion_r107650990
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileFormatWriter.scala
---
@@ -292,7 +292,10 @@ object FileFormatWriter extends Logging {
override def execute(iter: Iterator[InternalRow]): Set[String] = {
var fileCounter = 0
var recordsInFile: Long = 0L
- newOutputWriter(fileCounter)
+ // Skip the empty partition to avoid creating a mass of 'empty'
files.
+ if (iter.hasNext) {
+ newOutputWriter(fileCounter)
--- End diff --
Reading empty data should be fine too. I should preserve the schema. I am
pretty sure that we want this case because mine was reverted due to the case
above.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
