Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/17166#discussion_r107777651
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala ---
@@ -467,7 +474,7 @@ private[spark] class TaskSchedulerImpl
private[scheduler](
taskState: TaskState,
reason: TaskFailedReason): Unit = synchronized {
taskSetManager.handleFailedTask(tid, taskState, reason)
- if (!taskSetManager.isZombie && taskState != TaskState.KILLED) {
+ if (!taskSetManager.isZombie) {
--- End diff --
There might be a simple solution here to avoid extra overhead on
speculative tasks. We just need to check if the task index has been marked as
successful -- if so, we can skip calling reviveOffers(). How does this look?
```
- if (!taskSetManager.isZombie) {
+ if (!taskSetManager.isZombie &&
!taskSetManager.someAttemptSucceeded(tid)) {
```
Then in TaskSetManager,
```
+ def someAttemptSucceeded(tid: Long): Boolean = {
+ successful(taskInfos(tid).index)
+ }
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
