Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/15435#discussion_r107961224
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -644,21 +644,29 @@ class LogisticRegression @Since("1.2.0") (
val model = copyValues(new LogisticRegressionModel(uid,
coefficientMatrix, interceptVector,
numClasses, isMultinomial))
- // TODO: implement summary model for multinomial case
- val m = if (!isMultinomial) {
- val (summaryModel, probabilityColName) =
model.findSummaryModelAndProbabilityCol()
- val logRegSummary = new BinaryLogisticRegressionTrainingSummary(
+
+ val (summaryModel, probabilityColName, predictionColName)
+ = model.findSummaryModel()
+ val logRegSummary = if (!isMultinomial) {
--- End diff --
It doesn't appear you added any tests for this? Also, it is better for
reviewers if you do not squash your commits since we can then see what has
changed since the last pass was made.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
