Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17406#discussion_r107968297
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -3060,8 +3061,17 @@ object functions {
* @group collection_funcs
* @since 2.1.0
*/
- def from_json(e: Column, schema: String, options: java.util.Map[String,
String]): Column =
- from_json(e, DataType.fromJson(schema), options)
+ def from_json(e: Column, schema: String, options: java.util.Map[String,
String]): Column = {
+ // Until Spark-2.1, we use json strings for defining schemas here.
Since we add an user-friendly
+ // API in the DDL parser, we employ DDL formats for the case. To keep
back-compatibility,
+ // we use `fromJson` first, and then try the new API.
--- End diff --
How about?
```
In Spark 2.1, the user-provided schema has to be in JSON format. Since
Spark 2.2, the DDL format is also supported for schema.
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
