Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17394#discussion_r108016668
  
    --- Diff: sql/core/src/test/resources/sql-tests/results/describe.sql.out ---
    @@ -68,67 +68,74 @@ DESC FORMATTED t
     -- !query 5 schema
     struct<col_name:string,data_type:string,comment:string>
     -- !query 5 output
    -# Detailed Table Information                                               
    
    +a                          string                                      
    +b                          int                                         
    +c                          string                                      
    +d                          string                                      
     # Partition Information                                                
    -# Storage Information                                                  
     # col_name                 data_type               comment             
    -Comment:                   table_comment                               
    -Compressed:                No                                          
    -Created: 
    +c                          string                                      
    +d                          string                                      
    +                                                                       
    +# Detailed Table Information                                               
    
     Database:                  default                                     
    +Owner:                                                                 
    +Created: 
     Last Access: 
     Location: sql/core/spark-warehouse/t                           
    -Owner:                                                                 
    -Partition Provider:        Catalog                                     
    -Storage Desc Parameters:                                               
    -Table Parameters:                                                      
     Table Type:                MANAGED                                     
    -a                          string                                      
    -b                          int                                         
    -c                          string                                      
    -c                          string                                      
    -d                          string                                      
    -d                          string
    +Comment:                   table_comment                               
    +Table Parameters:                                                      
    +                                                                       
    +# Storage Information                                                  
    +Compressed:                No                                          
    +Storage Desc Parameters:                                               
    +Partition Provider:        Catalog
     
     
     -- !query 6
     DESC EXTENDED t
     -- !query 6 schema
     struct<col_name:string,data_type:string,comment:string>
     -- !query 6 output
    -# Detailed Table Information       CatalogTable(
    -   Table: `default`.`t`
    -   Created: 
    -   Last Access: 
    -   Type: MANAGED
    -   Schema: [StructField(a,StringType,true), 
StructField(b,IntegerType,true), StructField(c,StringType,true), 
StructField(d,StringType,true)]
    -   Provider: parquet
    -   Partition Columns: [`c`, `d`]
    -   Comment: table_comment
    -   Storage(Location: sql/core/spark-warehouse/t)
    -   Partition Provider: Catalog)                        
    -# Partition Information                                                
    -# col_name                 data_type               comment             
     a                          string                                      
     b                          int                                         
     c                          string                                      
    +d                          string                                      
    +# Partition Information                                                
    +# col_name                 data_type               comment             
     c                          string                                      
     d                          string                                      
    -d                          string
    +                                                                       
    +# Detailed Table Information                                               
    
    +Table: `default`.`t`
    +Created: 
    +Last Access: 
    +Type: MANAGED
    +Provider: parquet
    +Partition Columns: [`c`, `d`]
    +Comment: table_comment
    +Storage(Location: sql/core/spark-warehouse/t)
    +Partition Provider: Catalog
    +Schema: root
    + |-- a: string (nullable = true)
    + |-- b: integer (nullable = true)
    + |-- c: string (nullable = true)
    + |-- d: string (nullable = true)
    --- End diff --
    
    @cloud-fan Do we still need `Schema`, if the above info already has it? The 
only missing part is the nullability


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to