Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/17429#discussion_r108046277
--- Diff: R/pkg/R/functions.R ---
@@ -3548,7 +3548,7 @@ setMethod("row_number",
#' array_contains
#'
-#' Returns true if the array contain the value.
+#' Returns null if the array is null, true if the array contains the
value, and false otherwise.
--- End diff --
for null, we need to be more careful - `null` in JVM should show up as `NA`
in R.
also, should `true` be `TRUE` and `false` be `FALSE` to match R type?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
