Github user mridulm commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17276#discussion_r108052849
  
    --- Diff: 
core/src/main/scala/org/apache/spark/executor/ShuffleReadMetrics.scala ---
    @@ -80,13 +86,15 @@ class ShuffleReadMetrics private[spark] () extends 
Serializable {
       private[spark] def incRemoteBlocksFetched(v: Long): Unit = 
_remoteBlocksFetched.add(v)
       private[spark] def incLocalBlocksFetched(v: Long): Unit = 
_localBlocksFetched.add(v)
       private[spark] def incRemoteBytesRead(v: Long): Unit = 
_remoteBytesRead.add(v)
    +  private[spark] def incRemoteBytesReadToMem(v: Long): Unit = 
_remoteBytesReadToMem.add(v)
    --- End diff --
    
    The way it seems to be coded up, this will end up being everything fetched 
from shuffle - and we can already infer it : remote bytes read + local bytes 
read.
    Or did I miss something here ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to