Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/17430#discussion_r108092473 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala --- @@ -190,6 +190,7 @@ private[deploy] class SparkSubmitArguments(args: Seq[String], env: Map[String, S .orNull numExecutors = Option(numExecutors) .getOrElse(sparkProperties.get("spark.executor.instances").orNull) + queue = Option(queue).orElse(sparkProperties.get("spark.yarn.queue")).getOrElse("default") --- End diff -- I would be in favor of `orNull` instead of "default". `SparkSubmitArguments` reflects the arguments we set, since we don't set it, I think it would be better to be `null`. You could see other configurations here like `spark.driver.memory`, `spark.deploy.mode`, etc. Most of them indeed have default values, but here still use `null`.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org