Github user hhbyyh commented on a diff in the pull request:
https://github.com/apache/spark/pull/17407#discussion_r108094114
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/DecisionTreeRegressorSuite.scala
---
@@ -178,6 +178,22 @@ class DecisionTreeRegressorSuite
TreeTests.allParamSettings ++ Map("maxDepth" -> 0),
TreeTests.allParamSettings ++ Map("maxDepth" -> 0), checkModelData)
}
+
+ test("SPARK-20043: " +
+ "ImpurityCalculator builder fails for uppercase impurity type in
model read/write") {
+ val rdd = TreeTests.getTreeReadWriteData(sc)
+
+ val data: DataFrame =
+ TreeTests.setMetadata(rdd, Map.empty[Int, Int], numClasses = 0)
+
+ val dt = new DecisionTreeRegressor()
+ .setImpurity("Variance")
+ .setMaxDepth(2)
+
+ val model = dt.fit(data)
+
--- End diff --
the second unit test seems redundant for this case.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
