Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/17428#discussion_r108220965
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/QueryPlan.scala
---
@@ -289,6 +289,9 @@ abstract class QueryPlan[PlanType <:
QueryPlan[PlanType]] extends TreeNode[PlanT
case m: Map[_, _] => m
case d: DataType => d // Avoid unpacking Structs
case seq: Traversable[_] => seq.map(recursiveTransform)
+ case ExistenceJoin(exists: Attribute) =>
+ // `exists` must be an Attribute in ExistenceJoin
+ ExistenceJoin(transformExpression(exists).asInstanceOf[Attribute])
--- End diff --
Why is this change necessary? This smells for two reasons:
- `QueryPlan` shouldn't have know about such a detail. This means something
is wrong with the abstraction.
- Why do we want to change the attribute in an ExistenceJoin? It is
produced by the join, and we really should not replace it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
