Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/17355#discussion_r108255885
--- Diff: dev/run-pip-tests ---
@@ -75,18 +81,24 @@ for python in "${PYTHON_EXECS[@]}"; do
echo "Using $VIRTUALENV_BASE for virtualenv"
VIRTUALENV_PATH="$VIRTUALENV_BASE"/$python
rm -rf "$VIRTUALENV_PATH"
- mkdir -p "$VIRTUALENV_PATH"
- virtualenv --python=$python "$VIRTUALENV_PATH"
- source "$VIRTUALENV_PATH"/bin/activate
- # Upgrade pip & friends
- pip install --upgrade pip pypandoc wheel
- pip install numpy # Needed so we can verify mllib imports
+ if [ -n "$USE_CONDA" ]; then
+ conda create -y -p "$VIRTUALENV_PATH" python=$python numpy pandas
pip setuptools
--- End diff --
sounds reasonable, for packaging I've made it explicitly request Python 3.5
(at some point if PyPandoc doesn't make it into 3.6 on conda forge we should
ping them but no rush).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
