GitHub user tdas opened a pull request:
https://github.com/apache/spark/pull/17444
[SPARK-19876][SS] Follow up: Refactored BatchCommitLog to simplify logic
## What changes were proposed in this pull request?
Existing logic seemingly writes null to the BatchCommitLog, even though it
does additional checks to write '{}' (valid json) to the log. This PR
simplifies the logic by disallowing use of `log.add(batchId, metadata)` and
instead using `log.add(batchId)`. No question of specifying metadata, so no
confusion related to null.
## How was this patch tested?
Existing tests pass.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tdas/spark SPARK-19876-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/17444.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #17444
----
commit 4fa86a56f96ae120806fb75811f61128e1bd7abc
Author: Tathagata Das <[email protected]>
Date: 2017-03-27T21:22:59Z
Refactored BatchCommitLog to simplify logic
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
