Github user kunalkhamar commented on a diff in the pull request:
https://github.com/apache/spark/pull/17433#discussion_r108281320
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveSessionState.scala ---
@@ -40,12 +43,13 @@ import
org.apache.spark.sql.streaming.StreamingQueryManager
* @param catalog Internal catalog for managing table and database states
that uses Hive client for
* interacting with the metastore.
* @param sqlParser Parser that extracts expressions, plans, table
identifiers etc. from SQL texts.
- * @param metadataHive The Hive metadata client.
* @param analyzer Logical query plan analyzer for resolving unresolved
attributes and relations.
- * @param streamingQueryManager Interface to start and stop
- *
[[org.apache.spark.sql.streaming.StreamingQuery]]s.
- * @param queryExecutionCreator Lambda to create a [[QueryExecution]] from
a [[LogicalPlan]]
- * @param plannerCreator Lambda to create a planner that takes into
account Hive-specific strategies
+ * @param optimizer Logical query plan optimizer.
+ * @param planner Planner that converts optimized logical plans to
physical plans
--- End diff --
nit: the comment used to include "planner takes into account Hive-specific
strategies", lets add that back for completeness?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
