Github user tdas commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17444#discussion_r108313119
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/BatchCommitLog.scala
 ---
    @@ -45,33 +45,39 @@ import org.apache.spark.sql.SparkSession
     class BatchCommitLog(sparkSession: SparkSession, path: String)
       extends HDFSMetadataLog[String](sparkSession, path) {
     
    +  import BatchCommitLog._
    +
    +  def add(batchId: Long): Unit = {
    +    super.add(batchId, EMPTY_JSON)
    +  }
    +
    +  override def add(batchId: Long, metadata: String): Boolean = {
    +    throw new UnsupportedOperationException(
    --- End diff --
    
    If we want metadata down the road, we will refactor this class anyways to 
make it not HDFSMetadataLog[String] but HDFSMetadataLog[SomeCaseClass] (like 
OffsetSeqLog).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to