Github user wzhfy commented on the issue:

    https://github.com/apache/spark/pull/17446
  
    > Ideally, our optimizer rule BooleanSimplification should be able to 
remove the null literal, like what we did for true and false literals. Here, I 
think we should just assume our filter estimation does not depend on any other 
optimizer rules.
    
    Sorry I may miss some context, but I prefer enhancing 
`BooleanSimplification` to deal with null literals. There's no need to 
complicate estimation logic for those deterministic literals which can be 
removed by optimizer.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to