Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/17453#discussion_r108389791
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/plans/PlanTest.scala
---
@@ -127,7 +127,8 @@ abstract class PlanTest extends SparkFunSuite with
PredicateHelper {
(sameJoinPlan(j1.left, j2.left) && sameJoinPlan(j1.right,
j2.right)) ||
(sameJoinPlan(j1.left, j2.right) && sameJoinPlan(j1.right,
j2.left))
case _ if plan1.children.nonEmpty && plan2.children.nonEmpty =>
- (plan1.children, plan2.children).zipped.forall { case (c1, c2) =>
sameJoinPlan(c1, c2) }
+ plan1 == plan2 &&
--- End diff --
Why should they be equal? This implies that the entire subree is the same
as well right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
