Github user brkyvz commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17416#discussion_r108508229
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
    @@ -941,6 +965,12 @@ private[spark] object SparkSubmitUtils {
           val ri = ModuleRevisionId.newInstance(mvn.groupId, mvn.artifactId, 
mvn.version)
           val dd = new DefaultDependencyDescriptor(ri, false, false)
           dd.addDependencyConfiguration(ivyConfName, ivyConfName + "(runtime)")
    +      if (mvn.classifier.isDefined) {
    --- End diff --
    
    I have a feeling we might be missing it when we copy the files from the 
`local repo` to the ivy cache. The way the resolution works is as follows:
    
     1. Ivy searches local cache
     2. Ivy searches remote repos
     3. Ivy downloads from remote repo to local repo
     4. Ivy copies the file from local repo to cache
    
    Then the files are served from the local cache. Step 4 is called 
`retrieval` and happens on line 1159. I think that's what you're missing


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to