Github user ScrapCodes commented on the pull request:
https://github.com/apache/spark/pull/2294#issuecomment-56118218
Can you rebase to the tip of master and add tests in version 1.2 section:
https://github.com/apache/spark/blob/master/project/MimaExcludes.scala#L37
instead of 1.1.
Prashant Sharma
On Fri, Sep 19, 2014 at 4:42 AM, Burak Yavuz <notificati...@github.com>
wrote:
> @ScrapCodes <https://github.com/ScrapCodes>, I have some mima
> incompatibility issues here. I've added a few methods to the trait Matrix
> in MLlib, and that causes a MissingMethodProblem. I sealed the trait, and
> added the exclude statements to the MimaExcludes, but the tests still
fail.
> dev/mima passes on my local machine.
> Do you have any idea of what might be going on? The commits d162684
>
<https://github.com/apache/spark/commit/d16268496cefe06d8818b20721eede56a9de41a2>
> and
> 272feb9
>
<https://github.com/apache/spark/commit/272feb9f63517c52e1991988b4fbd8869a992dc4>
> were to address this issue.
>
> Can you please take a look?
>
> â
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/spark/pull/2294#issuecomment-56116462>.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
