Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/17419#discussion_r108742186
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/stat/SummarizerSuite.scala ---
@@ -335,4 +335,65 @@ class SummarizerSuite extends SparkFunSuite with
MLlibTestSparkContext {
assert(Buffer.totalCount(summarizer) === 6)
}
+ // TODO: this test should not be committed. It is here to isolate some
performance hotspots.
+ test("perf test") {
+ val n = 10000000
+ val rdd1 = sc.parallelize(1 to n).map { idx =>
+ OldVectors.dense(idx.toDouble)
+ }
+ val trieouts = 10
--- End diff --
I think that 10 times without warmup is too small for performance
measurement.
Can we use `Benchmark` class or add warmup run as `Benchmark` class does?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
