Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17342#discussion_r108775285
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/internal/SharedState.scala ---
    @@ -148,6 +149,8 @@ private[sql] class SharedState(val sparkContext: 
SparkContext) extends Logging {
     
     object SharedState {
     
    +  URL.setURLStreamHandlerFactory(new SparkUrlStreamHandlerFactory())
    --- End diff --
    
    > Say one day we need to support a third-party file system named "shaofs"
    
    So why not add the abstraction on that day? If `FsUrlStreamHandlerFactory` 
does what is needed here, and correctly support more than just the `hdfs` 
protocol (which isn't even enough to cover HDFS itself, which can be 
federated), then I don't see what the abstraction is buying us today.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to