Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r108786329
--- Diff:
core/src/test/java/org/apache/spark/launcher/SparkLauncherSuite.java ---
@@ -175,6 +175,33 @@ public void testChildProcLauncher() throws Exception {
.setConf(SparkLauncher.DRIVER_EXTRA_CLASSPATH,
System.getProperty("java.class.path"))
.addSparkArg(opts.CLASS, "ShouldBeOverriddenBelow")
.setMainClass(SparkLauncherTestApp.class.getName())
+ .autoShutdown(true)
--- End diff --
I remember mentioning that this isn't testing anything, maybe I forgot to
send the comment...
But since the parent process is not dying, this isn't actually doing
anything. If you want to test this here (and not just with the YARN tests you
added), you'll need to write a different test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
