GitHub user HyukjinKwon opened a pull request:
https://github.com/apache/spark/pull/17477
[SPARK-18692][BUILD][DOCS] Test Java 8 unidoc build on Jenkins
## What changes were proposed in this pull request?
This PR proposes to run Spark unidoc to test Javadoc 8 build as Javadoc 8
is easily re-breakable.
There are several problems with it:
- It introduces little extra bit of time to run the tests. In my case, it
took 1.5 mins more (`Elapsed :[94.8746569157]`). How it was tested is described
in "How was this patch tested?".
- > One problem that I noticed was that Unidoc appeared to be processing
test sources: if we can find a way to exclude those from being processed in the
first place then that might significantly speed things up.
(see @joshrosen's
[comment](https://issues.apache.org/jira/browse/SPARK-18692?focusedCommentId=15947627&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15947627))
To complete this automated build, It also suggests to fix existing Javadoc
breaks / ones introduced by test codes as described above.
There fixes were similar instances that previously fixed. Please refer
https://github.com/apache/spark/pull/15999 and
https://github.com/apache/spark/pull/16013
Note that this only fixes **errors** not **warnings**. Please see my
observation https://github.com/apache/spark/pull/17389#issuecomment-288438704
for spurious errors for warnings.
## How was this patch tested?
Manually via `jekyll build` for building tests. Also, tested via running
`dev/run-tests.py`.
This was tested via manually adding `time.time()` as below:
```diff
profiles_and_goals = build_profiles + sbt_goals
print("[info] Building Spark unidoc (w/Hive 1.2.1) using SBT with
these arguments: ",
" ".join(profiles_and_goals))
+ import time
+ st = time.time()
exec_sbt(profiles_and_goals)
+ print("Elapsed :[%s]" % str(time.time() - st))
```
produces
```
...
========================================================================
Building Unidoc API Documentation
========================================================================
...
[info] Main Java API documentation successful.
...
Elapsed :[94.8746569157]
...
...
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HyukjinKwon/spark SPARK-18692
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/17477.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #17477
----
commit 7ddb6eb11ed17c87355826db5bf2512b785042f5
Author: hyukjinkwon <gurwls...@gmail.com>
Date: 2017-03-30T03:55:09Z
Test Java 8 unidoc build on Jenkins
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
