Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17488#discussion_r109069839
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/FlatMapGroupsWithStateExec.scala
 ---
    @@ -68,6 +68,17 @@ case class FlatMapGroupsWithStateExec(
         val encSchemaAttribs = stateEncoder.schema.toAttributes
         if (isTimeoutEnabled) encSchemaAttribs :+ timestampTimeoutAttribute 
else encSchemaAttribs
       }
    +  // Converter for translating state Java objects to rows
    +  private val stateSerializer = {
    +    val encoderSerializer = stateEncoder.namedExpressions
    +    if (isTimeoutEnabled) {
    +      encoderSerializer :+ Literal(GroupStateImpl.NO_TIMESTAMP)
    +    } else {
    +      encoderSerializer
    +    }
    +  }
    +  private val stateDeserializer = 
stateEncoder.resolveAndBind().deserializer
    --- End diff --
    
    Can you comment that this has to happen on the driver so we don't forget 
why its here and move it?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to