Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17487#discussion_r109201000
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveTableValuedFunctions.scala
---
@@ -105,7 +105,7 @@ object ResolveTableValuedFunctions extends
Rule[LogicalPlan] {
override def apply(plan: LogicalPlan): LogicalPlan = plan
resolveOperators {
case u: UnresolvedTableValuedFunction if
u.functionArgs.forall(_.resolved) =>
- builtinFunctions.get(u.functionName) match {
+ builtinFunctions.get(u.functionName.toLowerCase) match {
--- End diff --
@hvanhovell Just did a search. Do we still need to check the case
sensitivity setting of the analyzer in this case?
Based on [the Hive
doc](https://cwiki.apache.org/confluence/display/Hive/LanguageManual+UDF),
> All Hive keywords are case-insensitive, including the names of Hive
operators and functions.
Our regular function names are always case insensitive. See the
[code](https://github.com/apache/spark/blob/master/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala#L74)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
