Github user samelamin commented on a diff in the pull request:
https://github.com/apache/spark/pull/17487#discussion_r109307800
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveTableValuedFunctions.scala
---
@@ -105,7 +105,7 @@ object ResolveTableValuedFunctions extends
Rule[LogicalPlan] {
override def apply(plan: LogicalPlan): LogicalPlan = plan
resolveOperators {
case u: UnresolvedTableValuedFunction if
u.functionArgs.forall(_.resolved) =>
- builtinFunctions.get(u.functionName) match {
+ builtinFunctions.get(u.functionName.toLowerCase) match {
--- End diff --
Ok I can revert but how will we test it since the apply method isn't being
called by the tests. They new up an unresolvedTableValuedFunction? Unless we
hardcore it in unresolvedTableValuedFunction to always be case insensitive then
I don't know how else to do it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
