Github user tgravescs commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2350#discussion_r17788554
  
    --- Diff: 
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ClientBase.scala ---
    @@ -415,41 +381,153 @@ trait ClientBase extends Logging {
             "1>", ApplicationConstants.LOG_DIR_EXPANSION_VAR + "/stdout",
             "2>", ApplicationConstants.LOG_DIR_EXPANSION_VAR + "/stderr")
     
    -    logInfo("Yarn AM launch context:")
    -    logInfo(s"  user class: ${args.userClass}")
    -    logInfo(s"  env:        $env")
    -    logInfo(s"  command:    ${commands.mkString(" ")}")
    -
         // TODO: it would be nicer to just make sure there are no null 
commands here
         val printableCommands = commands.map(s => if (s == null) "null" else 
s).toList
         amContainer.setCommands(printableCommands)
     
    -    setupSecurityToken(amContainer)
    +    
logDebug("===============================================================================")
    +    logDebug("Yarn AM launch context:")
    +    logDebug(s"    user class: ${Option(args.userClass).getOrElse("N/A")}")
    +    logDebug("    env:")
    +    launchEnv.foreach { case (k, v) => logDebug(s"        $k -> $v") }
    +    logDebug("    resources:")
    +    localResources.foreach { case (k, v) => logDebug(s"        $k -> $v")}
    +    logDebug("    command:")
    +    logDebug(s"        ${printableCommands.mkString(" ")}")
    +    
logDebug("===============================================================================")
     
         // send the acl settings into YARN to control who has access via YARN 
interfaces
         val securityManager = new SecurityManager(sparkConf)
         
amContainer.setApplicationACLs(YarnSparkHadoopUtil.getApplicationAclsForYarn(securityManager))
    +    setupSecurityToken(amContainer)
    +    UserGroupInformation.getCurrentUser().addCredentials(credentials)
     
         amContainer
       }
    +
    +  /**
    +   * Report the state of an application until it has exited, either 
successfully or
    +   * due to some failure, then return the application state.
    +   *
    +   * @param returnOnRunning Whether to also return the application state 
when it is RUNNING.
    +   * @param logApplicationReport Whether to log details of the application 
report every iteration.
    +   * @return state of the application, one of FINISHED, FAILED, KILLED, 
and RUNNING.
    +   */
    +  def monitorApplication(
    +      appId: ApplicationId,
    +      returnOnRunning: Boolean = false,
    +      logApplicationReport: Boolean = true): YarnApplicationState = {
    +    val interval = sparkConf.getLong("spark.yarn.report.interval", 1000)
    +    var lastState: YarnApplicationState = null
    +    while (true) {
    +      Thread.sleep(interval)
    +      val report = getApplicationReport(appId)
    +      val state = report.getYarnApplicationState
    +
    +      if (logApplicationReport) {
    +        logInfo(s"Application report from ResourceManager for app 
${appId.getId} (state: $state)")
    --- End diff --
    
    seems like we wouldn't need the "from ResourceManager" here.   Also could 
we put the full application id here instead of just the last bit. Its must 
easier to copy and paste if the user wants to grab it and use in yarn command 
of ui. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to