Github user okoethibm commented on a diff in the pull request:
https://github.com/apache/spark/pull/17455#discussion_r109586326
--- Diff:
core/src/main/scala/org/apache/spark/deploy/worker/ExecutorRunner.scala ---
@@ -157,7 +157,9 @@ private[deploy] class ExecutorRunner(
// Add webUI log urls
val baseUrl =
if (conf.getBoolean("spark.ui.reverseProxy", false)) {
-
s"/proxy/$workerId/logPage/?appId=$appId&executorId=$execId&logType="
+ // TODO get from master?
--- End diff --
Oops, that was a leftover from testing. In fact, the code is simpler when
consistently get the reverse proxy URL from the config along with the reverse
proxy flag, requiring both settings to be consistently set on all nodes. I
briefly considered a communication extension to send the master (reverse proxy)
URL to the executors, but felt it didn't really help
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
