Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/2450#discussion_r17799792
--- Diff:
core/src/test/scala/org/apache/spark/rdd/PairRDDFunctionsSuite.scala ---
@@ -478,6 +482,15 @@ class PairRDDFunctionsSuite extends FunSuite with
SharedSparkContext {
pairs.saveAsNewAPIHadoopFile[ConfigTestFormat]("ignored")
}
+ test("saveAsHadoopFile should respect configured output committers") {
+ val pairs = sc.parallelize(Array((new Integer(1), new Integer(1))))
+ val conf = new JobConf(sc.hadoopConfiguration)
+ conf.setOutputCommitter(classOf[FakeOutputCommitter])
+ pairs.saveAsHadoopFile("ignored", pairs.keyClass, pairs.valueClass,
classOf[FakeOutputFormat], conf)
+ val ran = sys.props.remove("mapred.committer.ran")
--- End diff --
This use of system properties here means this test can't run in parallel.
It might be good to do things:
1. Guard these tests with a lock so both can't run at the same time.
2. Clear the `mapred.committer.ran` property before starting the test
(otherwise you could get a false positive).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
