Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/17521
@gatorsmile @cloud-fan @ueshin Sorry .. i was on transit from work. Sure, i
will make a try. However , i wanted to understand this a bit more. In my
understanding, the current problem we are trying to address is only in our test
environment. In our tests as part of the infrastructure we want to keep the
timezone constant as we have hardcoded timestamp literals and in order to make
row comparisions work. Today, we do that in QueryTest.scala
[here](https://github.com/apache/spark/blob/f48461ab2bdb91cd00efa5a5ec4b0b2bc361e7a2/sql/core/src/test/scala/org/apache/spark/sql/QueryTest.scala#L43-46)
However, due to the change in the PR, this is happening a bit late as we
have created a cloned copy of SQLConf in PlanTest.scala (super class of
QueryTest.scala) in
[here](https://github.com/apache/spark/blob/master/sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/plans/PlanTest.scala#L32).
So in my understanding its this copy step where the configurations are used
the first time. Please correct me on this.. Thats the reason, i was suggesting
to move the setting of timezone up into PlanTest before the place where SQLConf
is cloned.
I will study the ConfigEntryWithDefault approach in the meantime.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
