Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/17543#discussion_r110010527
--- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
---
@@ -1281,10 +1281,24 @@ class DAGScheduler(
val failedStage = stageIdToStage(task.stageId)
val mapStage = shuffleIdToMapStage(shuffleId)
+ def invalidateLostFilesAndExecutor(): Unit = {
+ // Mark the map whose fetch failed as broken in the map stage
+ if (mapId != -1) {
+ mapStage.removeOutputLoc(mapId, bmAddress)
+ mapOutputTracker.unregisterMapOutput(shuffleId, mapId,
bmAddress)
+ }
+
+ // TODO: mark the executor as failed only if there were lots of
fetch failures on it
+ if (bmAddress != null) {
+ handleExecutorLost(bmAddress.executorId, filesLost = true,
Some(task.epoch))
+ }
+ }
+
if (failedStage.latestInfo.attemptId != task.stageAttemptId) {
logInfo(s"Ignoring fetch failure from $task as it's from
$failedStage attempt" +
s" ${task.stageAttemptId} and there is a more recent attempt
for that stage " +
s"(attempt ID ${failedStage.latestInfo.attemptId}) running")
+ invalidateLostFilesAndExecutor()
--- End diff --
Actually I'm confused about why you need this at all. It looks like the
map output location only gets added when the task is successful -- so what map
output loc. info needs to be invalidated?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
