Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17541#discussion_r110086068
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/physical/broadcastMode.scala
---
@@ -26,10 +26,7 @@ import org.apache.spark.sql.catalyst.InternalRow
trait BroadcastMode {
def transform(rows: Array[InternalRow]): Any
- /**
- * Returns true iff this [[BroadcastMode]] generates the same result as
`other`.
- */
- def compatibleWith(other: BroadcastMode): Boolean
--- End diff --
`BroadcastMode` is a field of `BroadcastExchangeExec`. Since we need to
canonicalize a `QueryPlan`, the `BroadcastMode` also need to be canonicalized.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
